xfs
[Top] [All Lists]

Re: [patch] xfsqa - fix 17[5-7] "unmount" typo

To: "David Chinner" <dgc@xxxxxxx>, xfs-dev <xfs-dev@xxxxxxx>
Subject: Re: [patch] xfsqa - fix 17[5-7] "unmount" typo
From: "Barry Naujok" <bnaujok@xxxxxxx>
Date: Tue, 13 May 2008 10:58:15 +1000
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <20080513005436.GQ155679365@xxxxxxx>
Organization: SGI
References: <20080513005436.GQ155679365@xxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Opera Mail/9.24 (Win32)
On Tue, 13 May 2008 10:54:36 +1000, David Chinner <dgc@xxxxxxx> wrote:

177 fails because mkfs tries to run on a mounted filesystem.
All 17[5-7] have the same problem - "unmount" is not the command
to unmount a filesystem.

Looks fine (or looks fie).

Signed-off-by: Dave Chinner <dgc@xxxxxxx>
---
 xfstests/175 |    2 +-
 xfstests/176 |    2 +-
 xfstests/177 |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Index: xfs-cmds/xfstests/175
===================================================================
--- xfs-cmds.orig/xfstests/175  2008-05-08 09:59:28.000000000 +1000
+++ xfs-cmds/xfstests/175       2008-05-13 10:50:01.581533095 +1000
@@ -40,7 +40,7 @@ _require_scratch
# test that we have DMAPI support
 _dmapi_scratch_mount
-unmount $SCRATCH_MNT > /dev/null 2>&1
+umount $SCRATCH_MNT > /dev/null 2>&1
# _test_punch args: blksize extsize_hint filesize "pp1 pp2 pp3" \
 #                                      "ps1 ps2 ps3" "pt1 pt2 pt3" "wp1 wp2" "ws1 
ws2" \
Index: xfs-cmds/xfstests/176
===================================================================
--- xfs-cmds.orig/xfstests/176  2008-05-08 09:59:28.000000000 +1000
+++ xfs-cmds/xfstests/176       2008-05-13 10:50:05.281061350 +1000
@@ -38,7 +38,7 @@ _require_scratch
# test that we have DMAPI support
 _dmapi_scratch_mount
-unmount $SCRATCH_MNT > /dev/null 2>&1
+umount $SCRATCH_MNT > /dev/null 2>&1
# _test_punch args: blksize extsize_hint filesize "pp1 pp2 pp3" \
 #                                      "ps1 ps2 ps3" "pt1 pt2 pt3" "wp1 wp2" "ws1 
ws2" \
Index: xfs-cmds/xfstests/177
===================================================================
--- xfs-cmds.orig/xfstests/177  2008-05-08 09:59:28.000000000 +1000
+++ xfs-cmds/xfstests/177       2008-05-13 10:49:58.181966589 +1000
@@ -40,7 +40,7 @@ _require_scratch
# test that we have DMAPI support
 _dmapi_scratch_mount
-unmount $SCRATCH_MNT > /dev/null 2>&1
+umount $SCRATCH_MNT > /dev/null 2>&1
_scratch_mkfs_xfs >/dev/null 2>&1 \
         || _fail "mkfs failed"




<Prev in Thread] Current Thread [Next in Thread>