Re: [PATCH 1/10] merge xfs_unmount into xfs_fs_put_super / xfs_fs_fill_super

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Mon, May 12, 2008 at 12:21:38PM +1000, David Chinner wrote:
> > +   if (mp->m_flags & XFS_MOUNT_DMAPI) {
> > +           XFS_SEND_UNMOUNT(mp, rip, DM_RIGHT_NULL, 0, 0,
> > +                           unmount_event_flags);
> > +   }
> 
> #ifdef HAVE_DMAPI around this chunk? I know the old code didn't,
> but it would then match the pre-unmount event hunk above...

We don't have #ifdefs around the other dmapi namespace bits.  In fact
I'd prefer to kill the one above aswell.  It's on my todo list because
I wan't to prove that using the normal event enabled macros are safe
in the unmount path first and just switch to those.