On Mon, May 05, 2008 at 05:53:16AM -0400, Christoph Hellwig wrote:
> It shouldn't be slow. You'd do the equivalent no_subtree check export
> without parent fh, so what we do is call the fh_to_dentry method
> and then call find_acceptable_alias to check if there's already an
> dentry around and if yes use that one. That latter part is what should
> fix your problem. If you want to be lazy you could just copy
> find_acceptable_alias into the xfs code and call it directly and let me
> clean up the mess later..
Sorry, this was written before my cup of tea in the morning.
find_acceptable_alias is of course a no-op in the no_subtree_check case,
and thus it's identical to what we're currently doing in the handle
code. So any problem you see here will also be seen in an nfs
environment with no_subtree_check, which is the sensible choise and
I think even the default these days. So we'd better fix the lacking
expiry in the core code. Cc'ing Greg as he's been fighting this code
quite a bit in the past.
|