| To: | Barry Naujok <bnaujok@xxxxxxx> |
|---|---|
| Subject: | Re: REVIEW: ASCII CI support in xfsprogs |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Thu, 1 May 2008 09:17:25 -0400 |
| Cc: | "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>, xfs-dev <xfs-dev@xxxxxxx> |
| In-reply-to: | <op.uagkf9jl3jf8g2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
| References: | <op.uagkf9jl3jf8g2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.17 (2007-11-01) |
On Thu, May 01, 2008 at 02:37:11PM +1000, Barry Naujok wrote: > I've reworked xfsprogs userspace tools from scratch with ASCII CI support > only. Much simpler than previous patches with Unicode CI. > > One issue that sort of bugs me a bit is I've maintained the same output as > the original IRIX mkfs.xfs with CI mode: > naming =version 2 bsize=4096 mixed-case=Y|N > > where "N" = CI enabled and "Y" = normal case-senstive filesystem. > > Should this be changed to something clearer? I'd prefer something cleaner. Like case-insensitive=Y|N. Otherwise the patch looks fine, but I wonder if you shouldn't better backport the xfs_dir* files from the kernel completely instead of applying the changes selectively, otherwise we'll get totoally out of sync codebases. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] Don't allow memory reclaim to wait on the filesystem in inode writeback, Christoph Hellwig |
|---|---|
| Next by Date: | Re: disk I/O error, Dovydas Sankauskas |
| Previous by Thread: | [PATCH] Don't allow memory reclaim to wait on the filesystem in inode writeback, David Chinner |
| Next by Thread: | Re: REVIEW: ASCII CI support in xfsprogs, Barry Naujok |
| Indexes: | [Date] [Thread] [Top] [All Lists] |