xfs
[Top] [All Lists]

Re: [PATCH] Don't allow memory reclaim to wait on the filesystem in inod

To: David Chinner <dgc@xxxxxxx>
Subject: Re: [PATCH] Don't allow memory reclaim to wait on the filesystem in inode writeback
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 1 May 2008 09:15:21 -0400
Cc: xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <20080501122611.GK108924158@xxxxxxx>
References: <20080501122611.GK108924158@xxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.17 (2007-11-01)
On Thu, May 01, 2008 at 10:26:11PM +1000, David Chinner wrote:
> Index: 2.6.x-xfs-new/fs/xfs/xfs_inode.c
> ===================================================================
> --- 2.6.x-xfs-new.orig/fs/xfs/xfs_inode.c     2008-04-28 16:35:23.000000000 
> +1000
> +++ 2.6.x-xfs-new/fs/xfs/xfs_inode.c  2008-05-01 20:04:55.151880341 +1000
> @@ -2986,7 +2986,7 @@ xfs_iflush_cluster(
>       ASSERT(pag->pag_ici_init);
>  
>       ilist_size = XFS_INODE_CLUSTER_SIZE(mp) * sizeof(xfs_inode_t *);
> -     ilist = kmem_alloc(ilist_size, KM_MAYFAIL);
> +     ilist = kmem_alloc(ilist_size, KM_NOFS);
>       if (!ilist)
>               return 0;

This should be KM_MAYFAIL | KM_NOFS, because KM_NOFS doesn't imply that
the allocation may fail.


<Prev in Thread] Current Thread [Next in Thread>