Re: [PATCH] always set a/c/mtime through ->setattr

[Al Viro <viro@xxxxxxxxxxxxxxxxxx>]

On Sat, May 31, 2008 at 09:24:45AM -0400, Christoph Hellwig wrote:
> On Sat, May 31, 2008 at 02:20:48PM +0100, Al Viro wrote:
> > And there's one more problem, promising very ugly code review: locking
> > rules for notify_change() had suddenly changed - you are calling it
> > without i_mutex now.  And ext3_setattr() is not happy - especially due
> > to this blind call of ext3_orphan_del() in there.  We can easily fix
> > that one, but you'll need to audit the rest of instances...
> 
> Yeah, I've actually started an audit of the setattr instance and there's
> even more crap turning up.  I'm working on a bigger series to sort these
> things out.

        Grabbing i_mutex may get very interesting on pagefault paths when
dirtying a page - locking rules are interesting there already...