xfs
[Top] [All Lists]

Re: REVIEW: Remove kmem_free build warnings

To: "Christoph Hellwig" <hch@xxxxxxxxxxxxx>
Subject: Re: REVIEW: Remove kmem_free build warnings
From: "Barry Naujok" <bnaujok@xxxxxxx>
Date: Wed, 21 May 2008 18:41:52 +1000
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
In-reply-to: <20080521081939.GA15771@infradead.org>
Organization: SGI
References: <20080521080648.82DCF58C4C29@chook.melbourne.sgi.com> <op.ubhvm6ax3jf8g2@pc-bnaujok.melbourne.sgi.com> <20080521081939.GA15771@infradead.org>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Opera Mail/9.24 (Win32)
On Wed, 21 May 2008 18:19:39 +1000, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:

Looks good, although you might want to pick up realloc as in my patch
while you're at it :)

Done and pushed to oss.

On Wed, May 21, 2008 at 06:10:08PM +1000, Barry Naujok wrote:


===========================================================================
fs/xfs/linux-2.6/kmem.c
===========================================================================

--- a/fs/xfs/linux-2.6/kmem.c   2008-05-21 18:06:48.000000000 +1000
+++ b/fs/xfs/linux-2.6/kmem.c   2008-05-21 18:04:44.400231547 +1000
@@ -90,7 +90,7 @@ kmem_zalloc_greedy(size_t *size, size_t
 }

 void
-kmem_free(void *ptr)
+kmem_free(const void *ptr)
 {
        if (((unsigned long)ptr < VMALLOC_START) ||
            ((unsigned long)ptr >= VMALLOC_END)) {

===========================================================================
fs/xfs/linux-2.6/kmem.h
===========================================================================

--- a/fs/xfs/linux-2.6/kmem.h 2008-05-21 18:06:48.000000000 +1000
+++ b/fs/xfs/linux-2.6/kmem.h 2008-05-21 18:05:33.673925302 +1000
@@ -58,7 +58,7 @@ extern void *kmem_alloc(size_t, unsigned
extern void *kmem_zalloc(size_t, unsigned int __nocast);
extern void *kmem_zalloc_greedy(size_t *, size_t, size_t, unsigned int
__nocast);
extern void *kmem_realloc(void *, size_t, size_t, unsigned int __nocast);
-extern void kmem_free(void *);
+extern void kmem_free(const void *);


 /*
  * Zone interfaces



---end quoted text---





<Prev in Thread] Current Thread [Next in Thread>