Re: [PATCH] streamline init/exit path

[Niv Sardi <xaiki@xxxxxxx>]

Christoph Hellwig <hch@xxxxxx> writes:

> On Wed, May 21, 2008 at 10:41:12AM +1000, Niv Sardi wrote:
>> Looks good, appart from the fact that I don't see the point of merging
>> xfs_{init,destroy}_zones into xfs_{init,exit}, appart from clobbering it
>> and making it less readeable.
>> 
>> could be:
>> error = xfs_init_zones();
>> if (error)
>>       goto out;
>> 
>> and all the other error cases will end with
>> xfs_destroy_zones();
>> 
>> That would look much more like the rest of the calls in these functions.
>
> I don't really see the point for splitting this up, it's not like it
> makes the initialization much simpler.  But hey, if that's the only
> objection I can changed it.

it's not splitting it up, just leaving it split up like it was, reduces
the function length, reduces the out: gotos, and makes it nicely fit in
one editor window =)

> At least someone is looking at my xfs patches :)

Cheers =)
-- 
Niv Sardi