Re: TAKE 981875 - xfs_dm_rdwr() needs to pass a vfsmount to dentry_open()

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Fri, May 16, 2008 at 01:10:48AM -0400, Christoph Hellwig wrote:
> On Fri, May 16, 2008 at 02:57:32PM +1000, Lachlan McIlroy wrote:
> > xfs_dm_rdwr() needs to pass a vfsmount to dentry_open()
> > 
> > We need a vfsmount pointer in xfs_dm_rdwr() but we are not
> > provided with one and there's no way to get to it.  So add
> > a m_vfsmount field to the xfs_mount structure and set it
> > up at mount time.  We can then access it through the xfs
> > inode.
> 
> Stong NACK for this crap, and double NACK for pushing this towards
> mainline.

No reply yet.  Folks, you realize this is an instant oops if you perform
dmapi operations after one fs instance has been unmounted?