Christoph Hellwig wrote:
Test 167 will leave runaway fsstress processes around in case killall is
not installed and thus make all following tests fail. This patch checks
for killall beeing installed and error out otherwise.
Looks reasonable.
However:
* could use set_prog_path like we do in common.config.
* I wonder if one could use "kill -$pgid" on the process group
for fsstress instead of killall (I've never tried it :).
--Tim
Signed-off-by: Christoph Hellwig <hch@xxxxxx>
Index: xfstests/167
===================================================================
RCS file: /cvs/xfs-cmds/xfstests/167,v
retrieving revision 1.3
diff -u -p -r1.3 167
--- xfstests/167 2 Aug 2007 16:19:56 -0000 1.3
+++ xfstests/167 15 May 2008 05:34:20 -0000
@@ -13,6 +13,7 @@ owner=dgc@xxxxxxx
seq=`basename $0`
echo "QA output created by $seq"
+killall="/usr/bin/killall"
here=`pwd`
tmp=/tmp/$$
rm -f $seq.full
@@ -43,6 +44,8 @@ workout()
_supported_fs xfs
_supported_os Linux
+[ -x $killall ] || _notrun "$killall executable not found"
+
_setup_testdir
_require_scratch
_scratch_mkfs_xfs >/dev/null 2>&1
|