Re: question about xfs_alloc_fix_freelist()

[David Chinner <dgc@xxxxxxx>]

On Fri, May 02, 2008 at 02:01:47PM -0700, Michael Nishimoto wrote:
> 
> The following code can be found near the end of xfs_alloc_fix_freelist:
> 
>                 if (targs.agbno == NULLAGBLOCK) {
>                         if (flags & XFS_ALLOC_FLAG_FREEING)
>                                 break;
>                         xfs_trans_brelse(tp, agflbp);
>                         args->agbp = NULL;
>                         return 0;
>                 }
> 
> Don't we need to release agbp too by calling xfs_trans_brelse(tp, agbp)?

I don't think so. AFAICT, The agbp (agf block) is linked into the
transaction and by this point we may have modified the AGF (think
multiple iterations of the loop to fill the free list). Given that
it may be modified, we shouldn't release it here but instead allow
the transaction commit/abort to do that for us at the appropriate
time.

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group