Re: [PATCH] Fix non-debug build for xfsidbg.c

[David Chinner <dgc@xxxxxxx>]

On Wed, Apr 30, 2008 at 05:17:24PM +1000, Lachlan McIlroy wrote:
> Dave, would the code look cleaner if iclog_bak was printed on a line by 
> itself?
> That way we wouldn't need the #else and we wouldn't be duplicating code.

Yup, probably a good idea. I've changed it to match how this is handled
in other places in xfsidbg.c:

@@ -5846,8 +5846,12 @@
             log->l_curr_cycle, log->l_prev_cycle, log->l_curr_block,
             log->l_prev_block);
        kdb_printf("iclog_bak: 0x%p  iclog_size: 0x%x (%d)  num iclogs: %d\n",
-               log->l_iclog_bak, log->l_iclog_size, log->l_iclog_size,
-               log->l_iclog_bufs);
+#ifdef DEBUG
+               log->l_iclog_bak,
+#else
+               NULL,
+#endif
+               log->l_iclog_size, log->l_iclog_size, log->l_iclog_bufs);
        kdb_printf("l_iclog_hsize %d l_iclog_heads %d\n",
                log->l_iclog_hsize, log->l_iclog_heads);
        kdb_printf("l_sectbb_log %u l_sectbb_mask %u\n",

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group