Re: [PATCH] xfs: reduce stack usage in xfs_bmap

xfs

Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc()

To:	Andi Kleen <andi@xxxxxxxxxxxxxx>
Subject:	Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc()
From:	Nathan Scott <nscott@xxxxxxxxxx>
Date:	Tue, 29 Apr 2008 09:52:33 +1000
Cc:	Christoph Hellwig <hch@xxxxxxxxxxxxx>, Denys Vlasenko <vda.linux@xxxxxxxxxxxxxx>, David Chinner <dgc@xxxxxxx>, xfs@xxxxxxxxxxx, Eric Sandeen <sandeen@xxxxxxxxxxx>, Adrian Bunk <bunk@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to:	<4815A7A5.9040507@xxxxxxxxxxxxxx>
Organization:	Aconex
References:	<200804261651.02078.vda.linux__2040.04651536724$1209223026$gmane$org@xxxxxxxxxxxxxx> <87iqy4wfjq.fsf@xxxxxxxxxxxxxxxxx> <20080426200701.GA10883@xxxxxxxxxxxxx> <20080426202630.GG17905@xxxxxxxxxxxxxxxxxx> <20080426202323.GA14245@xxxxxxxxxxxxx> <1209341212.23166.122.camel@xxxxxxxxxxxxxxxxx> <4815A7A5.9040507@xxxxxxxxxxxxxx>
Reply-to:	nscott@xxxxxxxxxx
Sender:	xfs-bounce@xxxxxxxxxxx

On Mon, 2008-04-28 at 12:32 +0200, Andi Kleen wrote:
> > and
> > its a side-effect of needing to do that (all the code
> > dealing with specifics of ondisk format is shared).
> 
> But does that really need "STATIC"? Seems doubtful to me.

In userspace STATIC is defined to nothing, and the tools
(and/or libxfs) directly call into numerous functions that
are (really) static in the kernel.

cheers.

-- 
Nathan

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), (continued) Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), David Chinner Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), Denys Vlasenko Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), David Chinner Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), Andi Kleen Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), Christoph Hellwig Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), Andi Kleen Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), Christoph Hellwig Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), Nathan Scott Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), Christoph Hellwig Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), Andi Kleen Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), Nathan Scott <=

Previous by Date:	Re: Problems with xfs_grow on large LVM + XFS filesystem 20TB size check 2 failed, Eric Sandeen
Next by Date:	Re: [PATCH, XFSQA] Don't run 175-177 if DMAPI is not supported, David Chinner
Previous by Thread:	Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), Andi Kleen
Next by Thread:	Your message to Mendo_recce awaits moderator approval, mendo_recce-bounces
Indexes:	[Date] [Thread] [Top] [All Lists]