xfs
[Top] [All Lists]

Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc()

To: Nathan Scott <nscott@xxxxxxxxxx>
Subject: Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 28 Apr 2008 01:56:29 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Andi Kleen <andi@xxxxxxxxxxxxxx>, Denys Vlasenko <vda.linux@xxxxxxxxxxxxxx>, David Chinner <dgc@xxxxxxx>, xfs@xxxxxxxxxxx, Eric Sandeen <sandeen@xxxxxxxxxxx>, Adrian Bunk <bunk@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <1209341212.23166.122.camel@xxxxxxxxxxxxxxxxx>
References: <200804261651.02078.vda.linux__2040.04651536724$1209223026$gmane$org@xxxxxxxxxxxxxx> <87iqy4wfjq.fsf@xxxxxxxxxxxxxxxxx> <20080426200701.GA10883@xxxxxxxxxxxxx> <20080426202630.GG17905@xxxxxxxxxxxxxxxxxx> <20080426202323.GA14245@xxxxxxxxxxxxx> <1209341212.23166.122.camel@xxxxxxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.17 (2007-11-01)
On Mon, Apr 28, 2008 at 10:06:51AM +1000, Nathan Scott wrote:
> Having to compile chunks of XFS code in both kernel and
> userspace is also wierd (relative to other drivers), and
> its a side-effect of needing to do that (all the code
> dealing with specifics of ondisk format is shared).

There would be neater ways to deal with that, but then again there
are more urgent things to tackle.  And for the time beeing using
STATIC to imply non-inline is actually a very useful hack for XFS.


<Prev in Thread] Current Thread [Next in Thread>