xfs
[Top] [All Lists]

Re: [PATCH] xfs: reduce stack usage in xfs_page_state_convert()

To: David Chinner <dgc@xxxxxxx>
Subject: Re: [PATCH] xfs: reduce stack usage in xfs_page_state_convert()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 27 Apr 2008 23:50:23 -0400
Cc: Denys Vlasenko <vda.linux@xxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, Eric Sandeen <sandeen@xxxxxxxxxxx>, Adrian Bunk <bunk@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20080427232317.GB103491721@xxxxxxx>
References: <200804270246.58828.vda.linux@xxxxxxxxxxxxxx> <20080427232317.GB103491721@xxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.17 (2007-11-01)
On Mon, Apr 28, 2008 at 09:23:17AM +1000, David Chinner wrote:
> No. That code is complex enough with only one copy of it around. I don't
> want two copies that differ subtly and hence have two different sets
> of nasty, rarely hit corner cases in them.

Actually the split makes some sense.  I had a ready patch to split out
releasepage which makes the whole code a lot nicer.  I didn't go forward
with it because I had this idea that it would get replaced by Chris
extent_map stuff ASAP..


<Prev in Thread] Current Thread [Next in Thread>