[Top] [All Lists]

Re: [PATCH, XFSQA] Don't run 175-177 if DMAPI is not supported

To: David Chinner <dgc@xxxxxxx>
Subject: Re: [PATCH, XFSQA] Don't run 175-177 if DMAPI is not supported
From: Timothy Shimmin <tes@xxxxxxx>
Date: Mon, 28 Apr 2008 10:09:44 +1000
Cc: xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <20080424065822.GY103491721@xxxxxxx>
References: <20080423013802.GJ103491721@xxxxxxx> <480EDE04.5080003@xxxxxxx> <20080424065822.GY103491721@xxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird (Macintosh/20080213)
David Chinner wrote:
On Wed, Apr 23, 2008 at 04:58:12PM +1000, Timothy Shimmin wrote:

_test_punch already does a umount $SCRATCH_MNT.
However, IMHO, it would probably be nicer if one could
use a _require_dmapi or really it may be simpler if
we could roll it into common.dmapi
so one just needs to include common.dmapi and
it would complain at that point if the kernel
didn't support it.

Sure, but we don't have that, and I'm not about to spend the time to
convert >20 tests to something like this. Right now I just want to
remove all the bloody silly test failures on mainline kernels.

All the other dmapi tests "not run" just fine, I want these to do
the same thing. Is that good enough to check in right now?



Sure, that's fine.

I was really just suggesting to put:

+# test that we have DMAPI support
+unmount $SCRATCH_MNT > /dev/null 2>&1

directly into common.dmapi - not as a function
but just as code to always execute.
As long as there is no output under normal circumstances from
this, then all dmapi tests should not require any change
and it is simpler (all they need is to include common.dmapi
which most do).
There may be an extra mount in some of the
tests (for those that want to keep it mounted) but who cares.
Why include common.dmapi if you don't require it to be supported :)


<Prev in Thread] Current Thread [Next in Thread>