xfs
[Top] [All Lists]

Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc()

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc()
From: Nathan Scott <nscott@xxxxxxxxxx>
Date: Mon, 28 Apr 2008 10:06:51 +1000
Cc: Andi Kleen <andi@xxxxxxxxxxxxxx>, Denys Vlasenko <vda.linux@xxxxxxxxxxxxxx>, David Chinner <dgc@xxxxxxx>, xfs@xxxxxxxxxxx, Eric Sandeen <sandeen@xxxxxxxxxxx>, Adrian Bunk <bunk@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20080426202323.GA14245@xxxxxxxxxxxxx>
Organization: Aconex
References: <200804261651.02078.vda.linux__2040.04651536724$1209223026$gmane$org@xxxxxxxxxxxxxx> <87iqy4wfjq.fsf@xxxxxxxxxxxxxxxxx> <20080426200701.GA10883@xxxxxxxxxxxxx> <20080426202630.GG17905@xxxxxxxxxxxxxxxxxx> <20080426202323.GA14245@xxxxxxxxxxxxx>
Reply-to: nscott@xxxxxxxxxx
Sender: xfs-bounce@xxxxxxxxxxx
On Sat, 2008-04-26 at 16:23 -0400, Christoph Hellwig wrote:
> 
> 
> 
> 
>                              Date: 
> Sat, 26 Apr 2008 16:23:23 -0400
> (Sun, 06:23 EST)
> 
> 
> On Sat, Apr 26, 2008 at 10:26:30PM +0200, Andi Kleen wrote:
> > > STATIC as defined by xfs already does this..
> > 
> > Weird. Unexpected. Different from everyone else. Is this some
> exercise in 
> > obfuscation?
> 
> The whole STATIC thing is weird to start with..
> 

Having to compile chunks of XFS code in both kernel and
userspace is also wierd (relative to other drivers), and
its a side-effect of needing to do that (all the code
dealing with specifics of ondisk format is shared).

cheers.

-- 
Nathan


<Prev in Thread] Current Thread [Next in Thread>