xfs
[Top] [All Lists]

Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc()

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc()
From: Denys Vlasenko <vda.linux@xxxxxxxxxxxxxx>
Date: Sun, 27 Apr 2008 01:45:11 +0200
Cc: David Chinner <dgc@xxxxxxx>, xfs@xxxxxxxxxxx, Eric Sandeen <sandeen@xxxxxxxxxxx>, Adrian Bunk <bunk@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date:user-agent:cc:references:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:message-id; bh=g2wRRL941LN3F4BEDCmUe0uMpe/W8Ibh9o0LO/wUOHM=; b=QCIO3pNKAm4BLshpB568ADaua6w6E+449E/1CV2IYERDvuaoT2X2llhFsf81TvTw/AJPlMBjok6y+AMiCvvJQUZ1u7Rw4BEFRSOJnqvctv+VFA3uFvSoo/8r8NuEuwiHvYGTbGXvSC2qJG/LWDq+Cd0FRTvVun6YELWwGfLA6ow=
Domainkey-signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:message-id; b=BdjfRnitkTIv9mLmrFc8WhCDGPEvqkk/QLzidZGgyiFvMed3BKFGpfcAcWNaegcZioKLY6oaJddeZD5g1FhssO5IxVsDvl5rWlf/OGpK1YfbCVRsXdVlEsdV6oyNUvwf/CZACWvhVEtvYQAFRNJSxWhy7OY7mqAOAlSr/70BEsY=
In-reply-to: <20080426200347.GA21021@xxxxxxxxxxxxx>
References: <200804261651.02078.vda.linux@xxxxxxxxxxxxxx> <20080426200347.GA21021@xxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: KMail/1.8.2
On Saturday 26 April 2008 22:03, Christoph Hellwig wrote:
> On Sat, Apr 26, 2008 at 04:51:02PM +0200, Denys Vlasenko wrote:
> > Hi David,
> > 
> > This patch reduces xfs_bmap_btalloc() stack usage by 50 bytes
> > by moving part of its body into a helper function.
> > 
> > This results in some variables not taking stack space in
> > xfs_bmap_btalloc() anymore.
> 
> I think this is a good idea, although I'd rather split the function at
> a local boundary.  The patch below (which passes xfsqa) does that
> by splitting out the handling of the most complicated nullfb case
> out.  It probably won't help reducing stack useage as much as yours,
> but it helps beeing able to read the code a little better.

It saves only 16 bytes of stack.
--
vda


<Prev in Thread] Current Thread [Next in Thread>