| To: | Andi Kleen <andi@xxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc() |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Sat, 26 Apr 2008 16:07:01 -0400 |
| Cc: | Denys Vlasenko <vda.linux@xxxxxxxxxxxxxx>, David Chinner <dgc@xxxxxxx>, xfs@xxxxxxxxxxx, Eric Sandeen <sandeen@xxxxxxxxxxx>, Adrian Bunk <bunk@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx |
| In-reply-to: | <87iqy4wfjq.fsf@xxxxxxxxxxxxxxxxx> |
| References: | <200804261651.02078.vda.linux__2040.04651536724$1209223026$gmane$org@xxxxxxxxxxxxxx> <87iqy4wfjq.fsf@xxxxxxxxxxxxxxxxx> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.17 (2007-11-01) |
On Sat, Apr 26, 2008 at 10:02:17PM +0200, Andi Kleen wrote: > Denys Vlasenko <vda.linux@xxxxxxxxxxxxxx> writes: > > > > Compile tested only. > > You should mark the helper noinline just to prevent gcc from possibly > inlining it. Even if it doesn't with your current compiler inline heuristics > vary widely between compiler versions. STATIC as defined by xfs already does this.. |
| Previous by Date: | Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), Christoph Hellwig |
|---|---|
| Next by Date: | [PATCH] kill xfs_uuid_unmount, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), Andi Kleen |
| Next by Thread: | Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), Andi Kleen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |