xfs
[Top] [All Lists]

Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc()

To: Denys Vlasenko <vda.linux@xxxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc()
From: Andi Kleen <andi@xxxxxxxxxxxxxx>
Date: Sat, 26 Apr 2008 22:02:17 +0200
Cc: David Chinner <dgc@xxxxxxx>, xfs@xxxxxxxxxxx, Eric Sandeen <sandeen@xxxxxxxxxxx>, Adrian Bunk <bunk@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <200804261651.02078.vda.linux__2040.04651536724$1209223026$gmane$org@xxxxxxxxxxxxxx> (Denys Vlasenko's message of "Sat, 26 Apr 2008 16:51:02 +0200")
References: <200804261651.02078.vda.linux__2040.04651536724$1209223026$gmane$org@xxxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.3 (gnu/linux)
Denys Vlasenko <vda.linux@xxxxxxxxxxxxxx> writes:
>
> Compile tested only.

You should mark the helper noinline just to prevent gcc from possibly
inlining it. Even if it doesn't with your current compiler inline heuristics
vary widely between compiler versions.

-Andi


<Prev in Thread] Current Thread [Next in Thread>