xfs
[Top] [All Lists]

Re: [PATCH, XFSQA] Don't run 175-177 if DMAPI is not supported

To: Timothy Shimmin <tes@xxxxxxx>
Subject: Re: [PATCH, XFSQA] Don't run 175-177 if DMAPI is not supported
From: David Chinner <dgc@xxxxxxx>
Date: Thu, 24 Apr 2008 16:58:22 +1000
Cc: David Chinner <dgc@xxxxxxx>, xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <480EDE04.5080003@xxxxxxx>
References: <20080423013802.GJ103491721@xxxxxxx> <480EDE04.5080003@xxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
On Wed, Apr 23, 2008 at 04:58:12PM +1000, Timothy Shimmin wrote:
> Hi,
> 
> _test_punch already does a umount $SCRATCH_MNT.
> However, IMHO, it would probably be nicer if one could
> use a _require_dmapi or really it may be simpler if
> we could roll it into common.dmapi
> so one just needs to include common.dmapi and
> it would complain at that point if the kernel
> didn't support it.

Sure, but we don't have that, and I'm not about to spend the time to
convert >20 tests to something like this. Right now I just want to
remove all the bloody silly test failures on mainline kernels.

All the other dmapi tests "not run" just fine, I want these to do
the same thing. Is that good enough to check in right now?

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group


<Prev in Thread] Current Thread [Next in Thread>