xfs
[Top] [All Lists]

Re: [PATCH 2/4] XFS: Return case-insensitive match for dentry cache

To: Barry Naujok <bnaujok@xxxxxxx>
Subject: Re: [PATCH 2/4] XFS: Return case-insensitive match for dentry cache
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 22 Apr 2008 00:55:26 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx
In-reply-to: <op.t9zphzsa3jf8g2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <20080421083103.433280025@xxxxxxxxxxxxxxxxxxxxxxx> <20080421083644.809426871@xxxxxxxxxxxxxxxxxxxxxxx> <20080421085947.GA10399@xxxxxxxxxxxxx> <op.t9zphzsa3jf8g2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.17 (2007-11-01)
On Tue, Apr 22, 2008 at 12:07:01PM +1000, Barry Naujok wrote:
>> What about just using kmalloc here?  We know the length of the name
>> anyway, so there is no point of allocating the maximum possible size.
>
> Not with the CI/NLS, the length could be different.

Well, even then we know the length to allocate because it needs to
be passed up in the nls_name.  For the utf8 case the allocated space
for the string might just be different from the number of characters.


<Prev in Thread] Current Thread [Next in Thread>