xfs
[Top] [All Lists]

Re: [PATCH 3/4] XFS: ASCII case-insensitive support

To: Barry Naujok <bnaujok@xxxxxxx>
Subject: Re: [PATCH 3/4] XFS: ASCII case-insensitive support
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 21 Apr 2008 05:03:20 -0400
Cc: xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx
In-reply-to: <20080421083645.247895324@xxxxxxxxxxxxxxxxxxxxxxx>
References: <20080421083103.433280025@xxxxxxxxxxxxxxxxxxxxxxx> <20080421083645.247895324@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.17 (2007-11-01)
> +extern struct dentry_operations xfs_ci_dentry_operations;

this one is not used nor does the variable exist.  Just kill it :)

> +static inline int xfs_sb_version_hasoldci(xfs_sb_t *sbp)
> +{
> +     return (XFS_SB_VERSION_NUM(sbp) == XFS_SB_VERSION_4) && \
> +             ((sbp)->sb_versionnum & XFS_SB_VERSION_BORGBIT);
> +}

Lots of superflous braces here.  Should be:

static inline int xfs_sb_version_hasoldci(xfs_sb_t *sbp)
{
        return (XFS_SB_VERSION_NUM(sbp) == XFS_SB_VERSION_4) &&
                (sbp->sb_versionnum & XFS_SB_VERSION_BORGBIT);
}

(and yes, the other xfs_sb_version_ helpers need fixups like that
aswell)


<Prev in Thread] Current Thread [Next in Thread>