xfs
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [REVIEW] - cleanup xfs_attr a bit

from [Christoph Hellwig] [Permanent Link][Original]
To: Barry Naujok <bnaujok@xxxxxxx>
Subject: Re: [REVIEW] - cleanup xfs_attr a bit
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 17 Apr 2008 14:27:02 -0400
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>, xfs-dev <xfs-dev@xxxxxxx>
In-reply-to: <op.t9qhhmhx3jf8g2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <op.t9qhhmhx3jf8g2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.17 (2007-11-01) 
On Thu, Apr 17, 2008 at 12:35:36PM +1000, Barry Naujok wrote:
> This patch starts using struct xfs_name more for the xattr code and
> is another step for using xfs_name in xfs_da_args.
>
> Also, the cred parameter is removed from xfs_attr_get and xfs_attr_fetch.

Looks good, but I'd really not expected a function called
xfs_attr_name_to_name to do the shutdown check.  Either keep it in the
callers or give the function a different name.
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: oss git tree busted...., David Chinner
Next by Date:  Re: [opensuse] nfs_update_inode: inode X mode changed, Y to Z, Adam Schrotenboer
Previous by Thread:  [REVIEW] - cleanup xfs_attr a bit, Barry Naujok
Next by Thread:  Re: [REVIEW] - cleanup xfs_attr a bit, Barry Naujok
Indexes:  [Date] [Thread] [Top] [All Lists]