xfs
[Top] [All Lists]

Re: [PATCH] split xfs_ioc_xattr

To: Niv Sardi <xaiki@xxxxxxxxxxxxx>
Subject: Re: [PATCH] split xfs_ioc_xattr
From: David Chinner <dgc@xxxxxxx>
Date: Wed, 16 Apr 2008 16:37:12 +1000
Cc: Christoph Hellwig <hch@xxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <ncclk3ejwam.fsf@xxxxxxx>
References: <20080319204014.GA23644@xxxxxx> <ncciqylf7q0.fsf@xxxxxxx> <20080414032940.GA10579@xxxxxx> <ncclk3ejwam.fsf@xxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
On Wed, Apr 16, 2008 at 01:47:13PM +1000, Niv Sardi wrote:
> Christoph Hellwig <hch@xxxxxx> writes:
> 
> > On Mon, Apr 14, 2008 at 01:14:47PM +1000, Niv Sardi wrote:
> >> 
> >> 
> >> Christoph Hellwig <hch@xxxxxx> writes:
> >> > The three subcases of xfs_ioc_xattr don't share any semantics and almost
> >> > no code, so split it into three separate helpers.
> >> >
> >> > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> >> 
> >> Looks good to me, aren't the likely() unlinkely() deprecated ? shouldn't
> >> they be killed ?
> >
> > Why would they be deprecated?
> 
> just an impression I had from on of Dave's comment to one of my patches:
> « Can we kill all the likely() crap out of here? Modern hardware
>   branch predictors are far better than static prediction hints. »

And the context which you haven't quoted? A repugnant hunk of code
with one broken use of likely() in two unnecessary 'if
(likely(!error) ...' branches, and 20 lines of my comment after the
above quote demonstrating of how to restructure it so it was neater,
faster and didn't need the prediction hints at all.

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group


<Prev in Thread] Current Thread [Next in Thread>