Re: [patch] ensure inodes are joined in xfs_itruncate

xfs

Re: [patch] ensure inodes are joined in xfs_itruncate_finish

To:	David Chinner <dgc@xxxxxxx>
Subject:	Re: [patch] ensure inodes are joined in xfs_itruncate_finish
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Thu, 10 Apr 2008 02:48:32 -0400
Cc:	xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to:	<20080410031405.GR108924158@xxxxxxx>
References:	<20080410031405.GR108924158@xxxxxxx>
Sender:	xfs-bounce@xxxxxxxxxxx
User-agent:	Mutt/1.5.17 (2007-11-01)

On Thu, Apr 10, 2008 at 01:14:05PM +1000, David Chinner wrote:
> On success, we still need to join the inode to the current
> transaction in xfs_itruncate_finish(). Fixes regression from
> error handling changes.
> 
> Note that this does some comment reformatting (to wrap at
> 80 columns) for comments that were modified.

The fix looks good to me, and makes xfsqa survive a little longer.
It now fails in xfs_alloc_ag_vextent/xfs_alloc_ag_vextent_near/
xfs_alloc_fix_len.  I suspect your next patch fixes that, but while
already commited it's unfortunately not in public CVS yet..

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[patch] ensure inodes are joined in xfs_itruncate_finish, David Chinner Re: [patch] ensure inodes are joined in xfs_itruncate_finish, Christoph Hellwig <=

Previous by Date:	Re: [patch] remove unnecessary periodic superblock logging., David Chinner
Next by Date:	Re: [patch] fix logic error in xfs_alloc_ag_vextent_near(), Christoph Hellwig
Previous by Thread:	[patch] ensure inodes are joined in xfs_itruncate_finish, David Chinner
Next by Thread:	PARTIAL TAKE 980084 - Don't error out on good I/Os in xfsbdstrat, David Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]