Sanitise xfs_log_force error checking.
xfs_log_force() is declared to return an error, but we almost never
check it. We don't need to check it in most cases; if there's a log
I/O error then we'll be shutting down the filesystem anyway and that
means we'll catch the error somewhere else.
However, on certain calls we should be returning an error - sync
transactions, fsync, sync writes, etc. so this isn't a pure black
and white distinction. Hence make xfs_log_force() a void function
that issues a warning to the syslog on error, and call
_xfs_log_force() in all the places where we actually care about the
error status returned.
Date: Thu Apr 10 10:59:08 AEST 2008
Workarea: chook.melbourne.sgi.com:/build/dgc/isms/2.6.x-xfs
Inspected by: xaiki@xxxxxxx
The following file(s) were checked into:
longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb
Modid: xfs-linux-melb:xfs-kern:30832a
fs/xfs/xfs_log.h - 1.81 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_log.h.diff?r1=text&tr1=1.81&r2=text&tr2=1.80&f=h
- Sanitise xfs_log_force error checking.
fs/xfs/xfs_log.c - 1.355 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_log.c.diff?r1=text&tr1=1.355&r2=text&tr2=1.354&f=h
- Sanitise xfs_log_force error checking.
fs/xfs/xfs_rw.c - 1.400 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_rw.c.diff?r1=text&tr1=1.400&r2=text&tr2=1.399&f=h
- Sanitise xfs_log_force error checking.
fs/xfs/linux-2.6/xfs_ksyms.c - 1.82 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_ksyms.c.diff?r1=text&tr1=1.82&r2=text&tr2=1.81&f=h
- Sanitise xfs_log_force error checking.
|