Re: [REVIEW #3] cleanup - remove bhv_vname

xfs

Re: [REVIEW #3] cleanup - remove bhv_vname_t

To:	Barry Naujok <bnaujok@xxxxxxx>
Subject:	Re: [REVIEW #3] cleanup - remove bhv_vname_t
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Wed, 9 Apr 2008 03:49:24 -0400
Cc:	"xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>, xfs-dev <xfs-dev@xxxxxxx>
In-reply-to:	<op.t9b1ien03jf8g2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References:	<op.t9b1ien03jf8g2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender:	xfs-bounce@xxxxxxxxxxx
User-agent:	Mutt/1.5.17 (2007-11-01)

On Wed, Apr 09, 2008 at 05:24:04PM +1000, Barry Naujok wrote:
> +     ASSERT(ip1);

No need for an assert here, there's only one caller and we know it's
there.


Except for that nitpick the patch looks fine to me.

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[REVIEW #3] cleanup - remove bhv_vname_t, Barry Naujok Re: [REVIEW #3] cleanup - remove bhv_vname_t, Barry Naujok Re: [REVIEW #3] cleanup - remove bhv_vname_t, Christoph Hellwig <=

Previous by Date:	PARTIAL TAKE 980084 - Catch errors returned from xfs_bmap_last_offset()., David Chinner
Next by Date:	[REVIEW] cleanup - refactor xfs_dir2_leafn_lookup_int(), Barry Naujok
Previous by Thread:	Re: [REVIEW #3] cleanup - remove bhv_vname_t, Barry Naujok
Next by Thread:	PARTIAL TAKE 980084 - Warn if errors come from block_truncate_page()., David Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]