Re: [REVIEW #2] cleanup - remove bhv_vname_t

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Tue, Apr 08, 2008 at 04:51:53AM -0400, Christoph Hellwig wrote:
> > +static inline int
> > +xfs_dir_check_canenter(uint resblks, struct xfs_trans *tp,
> > +                           struct xfs_inode *dp, struct xfs_name *name)
> > +{
> > +   if (resblks)
> > +           return 0;
> > +   return xfs_dir_canenter(tp, dp, name);;
> > +}
> 
> Probably makes sense to have this out of line.

Actuallt this is the only caller of xfs_dir_canenter with your patch so
you should merge the resblks check into xfs_dir_canenter.  Please also
add a comment on why we do the check.  Also resblks is normally the
last argument to functions, we should follow that convention here.