| To: | Niv Sardi <xaiki@xxxxxxx> |
|---|---|
| Subject: | Re: [patch] xfsqa 185 - remove uninitialised variables in golden output. |
| From: | David Chinner <dgc@xxxxxxx> |
| Date: | Tue, 8 Apr 2008 14:47:27 +1000 |
| Cc: | David Chinner <dgc@xxxxxxx>, xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx> |
| In-reply-to: | <nccr6dhhs7w.fsf@xxxxxxx> |
| References: | <20080408014023.GO108924158@xxxxxxx> <nccr6dhhs7w.fsf@xxxxxxx> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.2.1i |
On Tue, Apr 08, 2008 at 02:43:15PM +1000, Niv Sardi wrote: > David Chinner <dgc@xxxxxxx> writes: > > > Kill the output of uninitialised values when punching a hole. > > This prevents the test from passing on just about everything. > > > > Signed-off-by: Dave Chinner <dgc@xxxxxxx> > > Thanks dave, I've been meaning to do that for a long time, we might want > to kill the sid output too when it's not specified on command line (can > that change ? I've always seen it as 0). no idea. You can remove it as a separate patch if it is a problem. I'm going to check this one in now ;) Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [patch] xfsqa 185 - remove uninitialised variables in golden output., Niv Sardi |
|---|---|
| Next by Date: | [REVIEW] cleanup - remove bhv_vname_t, Barry Naujok |
| Previous by Thread: | Re: [patch] xfsqa 185 - remove uninitialised variables in golden output., Niv Sardi |
| Next by Thread: | TAKE 979087 - Test 091 fails on sector size != 512 bytes, David Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |