Re: [Patch] Per iclog callback chain lock

[David Chinner <dgc@xxxxxxx>]

On Mon, Apr 07, 2008 at 08:51:11AM -0400, Christoph Hellwig wrote:
> Looks good.  You might want to kill ic_callback_tail while you're at it
> as it's a write-only struct member.

No, it's not a write-only member. xlog_notify() queues to the tail
by doing:

    410                 cb->cb_next = NULL;
    411                 *(iclog->ic_callback_tail) = cb;
    412                 iclog->ic_callback_tail = &(cb->cb_next);

So we can't remove it. Changing the callback chain to use a
struct list_head makes more sense, but that's a separate patch....

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group