On Wed, Apr 02, 2008 at 03:31:37PM +1100, Niv Sardi wrote:
> David Chinner <dgc@xxxxxxx> writes:
> > On Wed, Apr 02, 2008 at 01:58:09PM +1100, Niv Sardi wrote:
> >> OK xfs-mustcheck-reset-dqcounts.patch
> >> OK xfs-mustcheck-dqflushall.patch
> >> OK xfs-mustcheck-acl-setmode.patch
> >> OK xfs-mustcheck-search-busy.patch
> >> EDITED xfs-mustcheck-compute-diff.patch # xfs_fs_cmn_err alignment
> > That patch doesn't have any calls to xfs_fs_cmn_err() in it. Can you
> > clarify, please?
> Oops, the edit was for:
> -+STATIC void /* success (>= minlen) */
> ++STATIC void
> as it didn't really make sense anymore.
> >> OK xfs-mustcheck-bulkstat-dinode.patch
> >> OK xfs-mustcheck-quiesce-fs.patch
> >> OK xfs-mustcheck-bdstrat.patch
> >> OK xfs-fix-error-prototypes.patch # not error handeling related
> >> OK xfs-mustcheck-acl-vremove.patch
> >> OK xfs-mustcheck-icsb-disable.patch
> >> OK xfs-mustcheck-ioend-unwritten.patch
> >> OK xfs-mustcheck-buf-associate.patch
> >> OK xfs-mustcheck-reserve-blocks.patch
> >> EDITED xfs-mustcheck-bawrite.patch # xfs_fs_cmn_err alignment
> > Which means?
> That's purely aesthetic, sometimes we split the string and keep it
> aligned, and sometimes we pad it left so that it fits, I prefer
Ok. If it involves splitting a string into 3 lines because of indentation,
then I tend to do one long line. i.e. this:
"xfs_qm_dquot_logitem_pushbuf: pushbuf error %d on qip %p, bp %p",
error, qip, bp);
" pushbuf error %d on qip %p, "
" bp %p", error, qip, bp);
The first is much easier to read and grep for....
> >> EDITED xfs-mustcheck-dqflush.patch # slight style change/typo
> > Details?
> -hence we nevre know if we've failed to flush a dquot to disk.
> +hence we never know if we've failed to flush a dquot to disk.
Oh, in the patch description....
> and xfs_fs_cmn_err stuff.
Same as above...
> >> OK xfs-mustcheck-reset-sbqflags.patch
> >> OK xfs-mustcheck-quotaoff.patch
> >> EDITED xfs-mustcheck-inactive.patch # slight style change/typo
> > Details?
> -correctly. if we fail to write the final quota off trnasaction,
> +correctly. if we fail to write the final quota off transaction,
Ah, that's from the quotaoff patch. No wonder I couldn't find the
But I also split the xfs_fs_cmn_err() in xfs-mustcheck-inactive
All fixed up. Thanks Niv.
SGI Australian Software Group