xfs
[Top] [All Lists]

Re: [Review] Improve XFS error checking and propagation

To: David Chinner <dgc@xxxxxxx>
Subject: Re: [Review] Improve XFS error checking and propagation
From: Niv Sardi <xaiki@xxxxxxxxxxxxx>
Date: Wed, 02 Apr 2008 13:58:09 +1100
Cc: xfs-dev <xfs-dev@xxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20080401230044.GS103491721@xxxxxxx> (David Chinner's message of "Wed, 2 Apr 2008 09:00:44 +1000")
References: <20080311010420.GD155407@xxxxxxx> <20080401230044.GS103491721@xxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.60 (i486-pc-linux-gnu)
David Chinner <dgc@xxxxxxx> writes:
> On Tue, Mar 11, 2008 at 12:04:21PM +1100, David Chinner wrote:
>> A recent paper at the FAST08 conference highlighted a large number
>> of unchecked error paths in Linux filesystems and I/O layers.  As a
>> subsystem, XFS had the highest aggregate numbers of bad error
>> propagation. A tarball which contains a quilt patch series of 32
>> patches aimed at improving this situation can be found here:
>> 
>> http://oss.sgi.com/~dgc/xfs/error-check/xfs-error-checking.tar.gz

All looks good except some minor typo-editing,

and

NOK xfs-mustcheck-quotamount.patch # need to check if can happen when forcing 
quotas

I'm not sure what happens if we really DO want quotas (specified on
mount line and such).

OK xfs-mustcheck-reset-dqcounts.patch
OK xfs-mustcheck-dqflushall.patch
OK xfs-mustcheck-acl-setmode.patch
OK xfs-mustcheck-search-busy.patch
EDITED xfs-mustcheck-compute-diff.patch # xfs_fs_cmn_err alignment
OK xfs-mustcheck-bmap-adjacent.patch
OK xfs-mustcheck-iflush-fork.patch # less error handeling !!
OK xfs-mustcheck-bulkstat-dinode.patch
OK xfs-mustcheck-quiesce-fs.patch
OK xfs-mustcheck-bdstrat.patch
OK xfs-fix-error-prototypes.patch # not error handeling related
OK xfs-mustcheck-acl-vremove.patch
OK xfs-mustcheck-icsb-disable.patch
OK xfs-mustcheck-ioend-unwritten.patch
OK xfs-mustcheck-buf-associate.patch
OK xfs-mustcheck-reserve-blocks.patch
EDITED xfs-mustcheck-bawrite.patch # xfs_fs_cmn_err alignment
OK xfs-mustcheck-bdwrite.patch
OK xfs-mustcheck-truncate-page.patch # might be incomplete
EDITED xfs-mustcheck-dqflush.patch # slight style change/typo
OK xfs-mustcheck-reset-sbqflags.patch
OK xfs-mustcheck-quotaoff.patch
EDITED xfs-mustcheck-inactive.patch # slight style change/typo
OK xfs-mustcheck-trans-reserve.patch
OK xfs-mustcheck-quota-trunc.patch
OK xfs-mustcheck-log-unmount.patch
OK xfs-mustcheck-free-extent.patch
OK xfs-mustcheck-xfs-imap.patch
OK xfs-mustcheck-bmap-last-offset.patch
OK xfs-mustcheck-trans-commit.patch
OK xfs-mustcheck-log-force.patch

Cheers, 
-- 
Niv Sardi


<Prev in Thread] Current Thread [Next in Thread>