On Tue, 08 Apr 2008 17:41:06 +1000, Christoph Hellwig <hch@xxxxxxxxxxxxx>
On Tue, Apr 08, 2008 at 04:50:26PM +1000, Barry Naujok wrote:
+static inline struct xfs_name *
+ struct xfs_name *namep,
+ struct dentry *dentry)
+ namep->name = dentry->d_name.name;
+ namep->len = dentry->d_name.len;
+ return namep;
As mentioned in my comment to the CI series: shouldn't you just use
a struct qstr instead of adding a new struct xfs_name?
Keeping a clean line between fs/xfs and fs/xfs/linux-2.6.
But this means more stack useage and more copies in every namespace
related operation. I don'y yhink it's a good tradeoff.
This will happen anyway for Unicode NLS support. Also, this patch
doesn't increase stack usage anywhere and some have reduced stack usage.
If you really care about a clear separatation add a #define or typedef
for xfs_name to struct qstr.
and qstr is platform dependant (yes, I know you said it's premature!)