xfs
[Top] [All Lists]

Re: [PATCH] xfs: reduce stack usage in xfs_page_state_convert()

To: David Chinner <dgc@xxxxxxx>
Subject: Re: [PATCH] xfs: reduce stack usage in xfs_page_state_convert()
From: Denys Vlasenko <vda.linux@xxxxxxxxxxxxxx>
Date: Mon, 28 Apr 2008 01:48:22 +0200
Cc: xfs@xxxxxxxxxxx, Eric Sandeen <sandeen@xxxxxxxxxxx>, Adrian Bunk <bunk@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date:user-agent:cc:references:in-reply-to:mime-version:content-disposition:message-id:content-type:content-transfer-encoding; bh=SlWLVBr5x8itYyoa1CPSrSPx0WX1Uh47lEUNT6Fging=; b=INM1xd1kCMFFb4axotMbobEkEw/tchdEWoBDqi44a2VbOgafH/DhZTXMWj1xnxnU+ZEG4huVrCQxudF7Lw6YRaO0DxbZGytbiV8HlwpYnC2GBWMoz6LsHHyF/scbyhQq/zkYMYOVO3bpCV76v4wk/INebHxfXfDTDBNe5ECntpE=
Domainkey-signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to:mime-version:content-disposition:message-id:content-type:content-transfer-encoding; b=YaiEU4vew7TYc6JDLZvYggYqRtG6WX5G9hMUMoZuYsfjrmn9p1drnWTRXmLoOxVZ+EKRX/LtsovVYmASHKBUMSR9HV84rmR9tSt6Z3XWAE5wdxYjKOz3+ELK4d2+LSjA47JV3qAREpv8KWe4JvLP3Nf/OV6nRoYj3Btc14lOeNM=
In-reply-to: <20080427232317.GB103491721@sgi.com>
References: <200804270246.58828.vda.linux@googlemail.com> <20080427232317.GB103491721@sgi.com>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: KMail/1.8.2
On Monday 28 April 2008 01:23, David Chinner wrote:
> > This patch reduces xfs_page_state_convert() stack usage by 16 bytes
> > by eliminating some local variables, and reducing the size
> > of scope for other locals.
> > 
> > Compile tested only.
> 
> Can you start testing your patches? if you are touching the writeback
> or allocator path, there's a pretty high barrier to having patches
> excepted, and testing them before is one of them. Go and download the

Its you who asked for patches. It's not like I decided
to nag you because I have nothing better to do. Actually,
my plate is pretty full with other things already.

> XFSQA suite from the xfs-cmds CVS tree on oss.sgi.com, and run your
> patches through it....


On Tuesday 22 April 2008 03:28, David Chinner wrote:
> Patches are welcome - I'd be over the moon if any of the known 4k
> stack advocates sent a stack reduction patch for XFS, but it seems
> that actually trying to fix the problems is much harder than
> resending a one line patch every few months....

So I went ahead and actually spend a good chunk of the week
trying to help you.

I believe that my patches were sufficiently well thought-out,
carefully implemented and reasonably tested (for a guy who
never used xfs, have no xfs partitions, and not exactly
planning to use xfs in the future).

> pretty high barrier to having patches accepted

I was honestly trying to help you. I am still willing
to do it, but at some point you have to carry some part
of a burden (maybe review and run testing?).

If you are not going to accept patches, why you are
accusing people of not sending them to you?
--
vda


<Prev in Thread] Current Thread [Next in Thread>