[PATCH] xfs: reduce stack usage in xfs_bmap

To:	David Chinner <dgc@xxxxxxx>
Subject:	[PATCH] xfs: reduce stack usage in xfs_bmap_btalloc()
From:	Denys Vlasenko <vda.linux@xxxxxxxxxxxxxx>
Date:	Sat, 26 Apr 2008 16:51:02 +0200
Cc:	xfs@xxxxxxxxxxx, Eric Sandeen <sandeen@xxxxxxxxxxx>, Adrian Bunk <bunk@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date:user-agent:cc:mime-version:content-type:message-id; bh=5SdU8wqbtLvdvQIq3rbQ40gnafP88O8z2JYdmOI5QT8=; b=QCa/RGpWYFAsbrTq34Sml/sAa+W7Z8kzD6jtFjckDGJedF8paqc/slrwOlm8fEo+oEn0tiEjww5phZYW/uJLa9GvZh9TPkq/vOhYvxb4t/d2hZfPKsBDRO/372gXd7t3Q39tiBM/yx5rs5IHcNgWg30coUUNvK/lpg2uYc0EWnk=
Domainkey-signature:	a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=from:to:subject:date:user-agent:cc:mime-version:content-type:message-id; b=JurhA4H3/QqpohKXDgoV01M/6oCjywC4vmtBS9eAU33DLc32RF/DTBLOYqW7eLwwbTyzvLvdH+9B/pwgYKQeo3+N5JS8xaCuUSpqWKFhU0yU/XL2Mfk0r2Se4NGCuDzEZN3qKNdEZntHd1L8OveBg/Epsv632IPSfmqAom4riqg=
Sender:	xfs-bounce@xxxxxxxxxxx
User-agent:	KMail/1.8.2

Hi David,

This patch reduces xfs_bmap_btalloc() stack usage by 50 bytes
by moving part of its body into a helper function.

This results in some variables not taking stack space in
xfs_bmap_btalloc() anymore.

The helper itself does not call anything stack-deep.
Stack-deep call to xfs_alloc_vextent() happen
in xfs_bmap_btalloc(), as before.

Compile tested only.

Signed-off-by: Denys Vlasenko <vda.linux@xxxxxxxxxxxxxx>
--
vda

stk1.diff
Description: Text Data

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), Denys Vlasenko <= Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), Eric Sandeen Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), Denys Vlasenko Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), Christoph Hellwig Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), Denys Vlasenko Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), David Chinner Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), Denys Vlasenko Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), David Chinner Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), Andi Kleen Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), Christoph Hellwig Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), Andi Kleen

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:	Re: REVIEW: 980021 - fix up noattr2 mount option, Christoph Hellwig
Next by Date:	Re: XFS drops create/delete files to 6.6% of EXT3 (software raid) and to 0.6% of EXT3 (3ware hardware raid), Emmanuel Florac
Previous by Thread:	I am out of the office until Monday 5/5/08. If you need immediate assistance please call, Economic Development
Next by Thread:	Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), Eric Sandeen
Indexes:	[Date] [Thread] [Top] [All Lists]

Previous by Date:

Re: REVIEW: 980021 - fix up noattr2 mount option, Christoph Hellwig

Next by Date:

Re: XFS drops create/delete files to 6.6% of EXT3 (software raid) and to 0.6% of EXT3 (3ware hardware raid), Emmanuel Florac

Previous by Thread:

I am out of the office until Monday 5/5/08. If you need immediate assistance please call, Economic Development

Next by Thread:

Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc(), Eric Sandeen

Indexes:

[Date] [Thread] [Top] [All Lists]