| To: | Barry Naujok <bnaujok@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/4] XFS: Name operation vector for hash and compare |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Mon, 21 Apr 2008 04:42:33 -0400 |
| Cc: | xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx |
| In-reply-to: | <20080421083644.158168432@chook.melbourne.sgi.com> |
| References: | <20080421083103.433280025@chook.melbourne.sgi.com> <20080421083644.158168432@chook.melbourne.sgi.com> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.17 (2007-11-01) |
> /*
> + * Search comparison results
> + */
> +typedef enum {
> + XFS_CMP_DIFFERENT, /* names are completely different */
> + XFS_CMP_EXACT, /* names are exactly the same */
> + XFS_CMP_CASE /* names are same but differ in case */
> +} xfs_dacmp_t;
Please don't add a typedef for this one, just use the enum type
directly.
Except for this this patch looks good to me.
|
| Previous by Date: | [PATCH 4/4] XFS: Unicode case-insensitive lookup implementation, Barry Naujok |
|---|---|
| Next by Date: | Re: [PATCH 2/4] XFS: Return case-insensitive match for dentry cache, Christoph Hellwig |
| Previous by Thread: | [PATCH 1/4] XFS: Name operation vector for hash and compare, Barry Naujok |
| Next by Thread: | [PATCH 2/4] XFS: Return case-insensitive match for dentry cache, Barry Naujok |
| Indexes: | [Date] [Thread] [Top] [All Lists] |