Re: [patch] fix logic error in xfs_alloc_ag_vextent_near()

["Barry Naujok" <bnaujok@xxxxxxx>]

On Thu, 10 Apr 2008 13:25:55 +1000, David Chinner <dgc@xxxxxxx> wrote:

> Fix a logic error in xfs_alloc_ag_vextent_near(). This is
> a regression introduced by the error handling changes.

Ah, I see how you made the mistake, looks good now.

(ie. was if (!xfs_alloc_compute_aligned() continue;)

> Signed-off-by: Dave Chinner <dgc@xxxxxxx>
> ---
>  fs/xfs/xfs_alloc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: 2.6.x-xfs-new/fs/xfs/xfs_alloc.c
> ===================================================================
> --- 2.6.x-xfs-new.orig/fs/xfs/xfs_alloc.c	2008-04-10 10:00:50.000000000  
> +1000
> +++ 2.6.x-xfs-new/fs/xfs/xfs_alloc.c	2008-04-10 13:10:17.948126881 +1000
> @@ -838,7 +838,7 @@ xfs_alloc_ag_vextent_near(
>  			XFS_WANT_CORRUPTED_GOTO(i == 1, error0);
>  			xfs_alloc_compute_aligned(ltbno, ltlen, args->alignment,
>  					args->minlen, &ltbnoa, &ltlena);
> -			if (ltlena >= args->minlen)
> +			if (ltlena < args->minlen)
>  				continue;
>  			args->len = XFS_EXTLEN_MIN(ltlena, args->maxlen);
>  			xfs_alloc_fix_len(args);