Re: [REVIEW] cleanup - refactor xfs_dir2_leafn_lookup_int()

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Wed, Apr 09, 2008 at 06:02:06PM +1000, Barry Naujok wrote:
> +     if (curbp) {
> +             /* For addname, giving back a free block. */

Given the function is only for addname anymore the first half of the
comment doesn't make sense anymore.

> +             if (dep->namelen == args->namelen && memcmp(dep->name,
> +                                     args->name, args->namelen) == 0) {
> +                     args->inumber = be64_to_cpu(dep->inumber);
> +                     *indexp = index;
> +                     state->extravalid = 1;
> +                     state->extrablk.bp = curbp;
>                       state->extrablk.blkno = curdb;
> +                     state->extrablk.index = (int)((char *)dep -
> +                                                     (char *)curbp->data);
>                       state->extrablk.magic = XFS_DIR2_DATA_MAGIC;
> +                     return XFS_ERROR(EEXIST);
>               }
>       }
>       /*
> +      * Didn't find a match.
> +      * If we are holding a buffer, give it back in case our caller
> +      * finds it useful.
> +      */
> +     if (curbp) {
> +             /* Giving back a data block. */
> +             state->extravalid = 1;
> +             state->extrablk.bp = curbp;
> +             state->extrablk.index = -1;
> +             state->extrablk.blkno = curdb;
> +             state->extrablk.magic = XFS_DIR2_DATA_MAGIC;

Might be worth factoring these two out using a goto

Otherwise the patch looks good.