| To: | "Josef 'Jeff' Sipek" <jeffpc@xxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] do not test return value of xfs_bmap_*_count_leaves |
| From: | Ruben Porras <ruben.porras@xxxxxxxxxxx> |
| Date: | Fri, 04 Apr 2008 17:08:30 +0200 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20080328154605.GA28322@josefsipek.net> |
| References: | <1206719011.8339.6.camel@marzo> <20080328154605.GA28322@josefsipek.net> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
Am Freitag, den 28.03.2008, 11:46 -0400 schrieb Josef 'Jeff' Sipek: > On Fri, Mar 28, 2008 at 04:43:31PM +0100, Ruben Porras wrote: > > These functions, xfs_bmap_count_leaves and xfs_bmap_disk_count_leaves, > > return always 0. Therefore it is not necessary to test the return value. > > If it always returns 0, why not make it void? better, patch attached. -- RubÃn Porras Campo Telekommunikation Engineer LinWorks GmbH Robert-Koch-StraÃe 9; 64331 Weiterstadt http://www.linworks.de
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Patch] unique per-AG inode generation number initialisation, Hans-Peter Jansen |
|---|---|
| Next by Date: | [PATCH] fix comments related to xfs_write_file, Ruben Porras |
| Previous by Thread: | xfs_check running out of memory, Fong Vang |
| Next by Thread: | [PATCH] fix comments related to xfs_write_file, Ruben Porras |
| Indexes: | [Date] [Thread] [Top] [All Lists] |