xfs
[Top] [All Lists]

Re: [PATCH 5/7] XFS: Unicode case-insensitive lookup implementation

To: David Chinner <dgc@xxxxxxx>
Subject: Re: [PATCH 5/7] XFS: Unicode case-insensitive lookup implementation
From: Jamie Lokier <jamie@xxxxxxxxxxxxx>
Date: Fri, 4 Apr 2008 00:00:04 +0100
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Barry Naujok <bnaujok@xxxxxxx>, xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx
In-reply-to: <20080403222059.GU103491721@sgi.com>
Mail-followup-to: David Chinner <dgc@xxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Barry Naujok <bnaujok@xxxxxxx>, xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx
References: <20080402062508.017738664@chook.melbourne.sgi.com> <20080402062709.011126702@chook.melbourne.sgi.com> <20080403171450.GB22385@infradead.org> <20080403222059.GU103491721@sgi.com>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.13 (2006-08-11)
David Chinner wrote:
> On Thu, Apr 03, 2008 at 01:14:50PM -0400, Christoph Hellwig wrote:
> > Validating file names is not the filesystem job.  In fact it's utterly
> > stupid, a unix filename is a sequence of bytes without special meaning
> > except for ., .., / and \0
> 
> So you're suggesting that we should rely on userspace being bug free
> and always only using valid unicode sequences in it's names?

You can bet that one person's "invalid unicode sequence" will have
been used as a valid filename on someone else's filesystem even using
unicode.  Meanings of "invalid unicode sequence" vary (a lot)
depending on which standard you follow.  Annoyance will come when they
try to copy the directory.

Such things are no great surprise on Windows and MacOS (both of which
do even worse things than rejecting sequences), but in POSIX land we
expect things like that to work.

The rules for ., .., / and \0, and accepting the rest as a blob, have
been well defined and understood for a long time.

-- Jamie


<Prev in Thread] Current Thread [Next in Thread>