On Wed, Apr 02, 2008 at 09:13:48AM +1000, David Chinner wrote:
> Introduce an iclog callback chain lock.
>
> Rather than use the icloglock for protecting the iclog completion
> callback chain, use a new per-iclog lock so that walking the
> callback chain doesn't require holding a global lock.
>
> This reduces contention on the icloglock during log buffer I/O
> completion as the callback chain lock is take for every callback
> that is issued.
This is not accurate - the callback chain is removed in bulk
then walked without the lock, but will loop over the iclog
chain in case callbacks were added while processing the chain
(not sure if that can even happen, though).
[mental note - don't write patch descriptions before first coffee
completion occurs.]
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
|