Re: [PATCH] cleanup root inode handling in xfs_fs_fill

xfs

Re: [PATCH] cleanup root inode handling in xfs_fs_fill_super

To:	Christoph Hellwig <hch@xxxxxx>
Subject:	Re: [PATCH] cleanup root inode handling in xfs_fs_fill_super
From:	"Josef 'Jeff' Sipek" <jeffpc@xxxxxxxxxxxxxx>
Date:	Fri, 21 Mar 2008 14:06:43 -0400
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20080319204724.GA24271@xxxxxx>
References:	<20080319204724.GA24271@xxxxxx>
Sender:	xfs-bounce@xxxxxxxxxxx
User-agent:	Mutt/1.5.16 (2007-06-11)

On Wed, Mar 19, 2008 at 09:47:24PM +0100, Christoph Hellwig wrote:
>  - rename rootvp to root for clarify
>  - remove useless vn_to_inode call
>  - check is_bad_inode before calling d_alloc_root
>  - use iput instead of VN_RELE in the error case
 
Looks good.

Josef 'Jeff' Sipek.

-- 
FORTUNE PROVIDES QUESTIONS FOR THE GREAT ANSWERS: #19
A:      To be or not to be.
Q:      What is the square root of 4b^2?

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] cleanup root inode handling in xfs_fs_fill_super, Christoph Hellwig Re: [PATCH] cleanup root inode handling in xfs_fs_fill_super, Josef 'Jeff' Sipek <=

Previous by Date:	Re: [PATCH] kill mrlock_t, Josef 'Jeff' Sipek
Next by Date:	Re: BUG: xfs on linux lvm - lvconvert random hungs when doing i/o, Josef 'Jeff' Sipek
Previous by Thread:	[PATCH] cleanup root inode handling in xfs_fs_fill_super, Christoph Hellwig
Next by Thread:	xfsqa failures, Josef 'Jeff' Sipek
Indexes:	[Date] [Thread] [Top] [All Lists]