Re: [PATCH] fix dir2 shortform structures on ARM old ABI

[Eric Sandeen <sandeen@xxxxxxxxxxx>]

Eric Sandeen wrote:
> Eric Sandeen wrote:
> 
>> I've helpfully provided structure layouts for the structures you mention
>> in the attached files, for your diffing pleasure.  I think you'll find
>> that it's not exactly as you described.
> 
> Ah hell the arm structs I attached were for oldabi.  It's what I get for
> saving this fun work for late at night ;)
> 
> Attached are eabi structs; still only xfs_dir2_data_entry, xfs_dinode
> and xfs_log_item seem to be affected by end-of-struct padding, of the
> structures you mention.  And xfs_log_item isn't a disk structure...
> 
> which brings me back to, what specific failures do you see as a result
> of end-of-struct padding on these structs?

... especially since the layout is identical to ia64, padding and all!

Ok must.. stop.. replying.. to.. self.

-Eric