| To: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] fix dir2 shortform structures on ARM old ABI |
| From: | Timothy Shimmin <tes@xxxxxxx> |
| Date: | Tue, 18 Mar 2008 10:35:32 +1100 |
| Cc: | "Josef 'Jeff' Sipek" <jeffpc@xxxxxxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx> |
| In-reply-to: | <47DEB930.7020108@xxxxxxxxxxx> |
| References: | <47DB4181.7040603@xxxxxxxxxxx> <20080315041722.GA25621@xxxxxxxxxxxxxx> <47DB4F4F.8030407@xxxxxxxxxxx> <20080315042703.GA28242@xxxxxxxxxxxxxx> <47DB51A3.70200@xxxxxxxxxxx> <20080315045147.GB28242@xxxxxxxxxxxxxx> <47DEB930.7020108@xxxxxxxxxxx> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Thunderbird 2.0.0.9 (Macintosh/20071031) |
Eric Sandeen wrote: Josef 'Jeff' Sipek wrote:Josef 'Jeff' Sipek, wondering exactly how passionate one can get about structure member alignment :)Very. ;) Tossing packed at all the ondisk stuctures bloats things badly on ia64. cvs/linux-2.6-xfs> wc -l before.dis 166688 before.dis cvs/linux-2.6-xfs> wc -l after.dis 182294 after.dis That's +15606 lines. http://digitalvampire.org/blog/index.php/2006/07/31/why-you-shouldnt-use-__attribute__packed/ Interesting. So the problem there is that gcc is doing the wrong thing on some arches (the example being ia64, sparc64). --Tim |
| Previous by Date: | 2.6.24.3 nfs server on xfs keeps producing nfsd: non-standard errno: -117, Stuart Rowan |
|---|---|
| Next by Date: | Re: [PATCH] fix dir2 shortform structures on ARM old ABI, Josef 'Jeff' Sipek |
| Previous by Thread: | Re: [RFC][PATCH 1/1] XFS: annotate all on-disk structures with __ondisk, Josef 'Jeff' Sipek |
| Next by Thread: | Re: [PATCH] fix dir2 shortform structures on ARM old ABI, Josef 'Jeff' Sipek |
| Indexes: | [Date] [Thread] [Top] [All Lists] |