Re: [PATCH] fix dir2 shortform structures on ARM old ABI

[Eric Sandeen <sandeen@xxxxxxxxxxx>]

Josef 'Jeff' Sipek wrote:

> Josef 'Jeff' Sipek, wondering exactly how passionate one can get about
> structure member alignment :)

Very.  ;)

Tossing packed at all the ondisk stuctures bloats things badly on ia64.

cvs/linux-2.6-xfs> wc -l before.dis
166688 before.dis
cvs/linux-2.6-xfs> wc -l after.dis
182294 after.dis

That's +15606 lines.

http://digitalvampire.org/blog/index.php/2006/07/31/why-you-shouldnt-use-__attribute__packed/

Please, don't do this.

_Annotating_ ondisk structures sounds good to me, assuming something can
be done with it (i.e., testing for holes - I'd thought of this a while
ago too, but never came up with anything to make use of it) but don't
pack stuff just for fun.

-Eric