[Top] [All Lists]

Re: [PATCH, RFC] - remove mounpoint UUID code

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH, RFC] - remove mounpoint UUID code
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 8 Mar 2008 06:54:27 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <47D20F78.7000103@xxxxxxxxxxx>
References: <47D20F78.7000103@xxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.17 (2007-11-01)
On Fri, Mar 07, 2008 at 10:00:56PM -0600, Eric Sandeen wrote:
> It looks like all of the below is unused... and according
> to Nathan,
> "dont think it even got used/implemented anywhere, but i think it 
> was meant to be an auto-mount kinda thing... such that when you look 
> up at that point, it knows to mount the device with that uuid there, 
> if its not already it was never really written anywhere ... just an 
> idea in doug doucettes brain i think."
> Think it'll ever go anywhere, or should it get pruned?
> The below builds; not at all tested, until I get an idea if it's worth
> doing.  Need to double check that some structures might not need padding
> out to keep things compatible/consistent...

This looks fine to me.  But please keep the XFS_DINODE_FMT_UUID enum
value and add a big comment close to it documenting what it was an maybe
a approximate removal date so people who care about it can look it up
in the SCM history easily.

<Prev in Thread] Current Thread [Next in Thread>