xfs
[Top] [All Lists]

[PATCH 3/3] kill XFS_ICSB_SB_LOCKED

To: xfs@xxxxxxxxxxx
Subject: [PATCH 3/3] kill XFS_ICSB_SB_LOCKED
From: Christoph Hellwig <hch@xxxxxx>
Date: Wed, 19 Mar 2008 21:45:15 +0100
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.3.28i
With the last two patches XFS_ICSB_SB_LOCKED is never checked and
only superflously passed to xfs_icsb_count, so kill it.


Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Index: linux-2.6-xfs/fs/xfs/xfs_mount.c
===================================================================
--- linux-2.6-xfs.orig/fs/xfs/xfs_mount.c       2008-03-08 15:51:26.000000000 
+0100
+++ linux-2.6-xfs/fs/xfs/xfs_mount.c    2008-03-08 15:51:26.000000000 +0100
@@ -2193,7 +2193,7 @@ xfs_icsb_disable_counter(
        if (!test_and_set_bit(field, &mp->m_icsb_counters)) {
                /* drain back to superblock */
 
-               xfs_icsb_count(mp, &cnt, 
XFS_ICSB_SB_LOCKED|XFS_ICSB_LAZY_COUNT);
+               xfs_icsb_count(mp, &cnt, XFS_ICSB_LAZY_COUNT);
                switch(field) {
                case XFS_SBS_ICOUNT:
                        mp->m_sb.sb_icount = cnt.icsb_icount;
Index: linux-2.6-xfs/fs/xfs/xfs_mount.h
===================================================================
--- linux-2.6-xfs.orig/fs/xfs/xfs_mount.h       2008-03-08 15:51:24.000000000 
+0100
+++ linux-2.6-xfs/fs/xfs/xfs_mount.h    2008-03-08 15:51:26.000000000 +0100
@@ -206,7 +206,6 @@ typedef struct xfs_icsb_cnts {
 
 #define XFS_ICSB_FLAG_LOCK     (1 << 0)        /* counter lock bit */
 
-#define XFS_ICSB_SB_LOCKED     (1 << 0)        /* sb already locked */
 #define XFS_ICSB_LAZY_COUNT    (1 << 1)        /* accuracy not needed */
 
 extern int     xfs_icsb_init_counters(struct xfs_mount *);


<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH 3/3] kill XFS_ICSB_SB_LOCKED, Christoph Hellwig <=