| To: | David Chinner <dgc@xxxxxxx> |
|---|---|
| Subject: | Re: [patch] fix inode leak in xfs_iget_core() |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Sun, 2 Mar 2008 23:04:58 -0500 |
| Cc: | xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx> |
| In-reply-to: | <20080223092255.GA21453@infradead.org> |
| References: | <20080223061924.GI155259@sgi.com> <20080223092255.GA21453@infradead.org> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.17 (2007-11-01) |
On Sat, Feb 23, 2008 at 04:22:55AM -0500, Christoph Hellwig wrote: > On Sat, Feb 23, 2008 at 05:19:24PM +1100, David Chinner wrote: > > If the radix_tree_preload() fails, we need to destroy the > > inode we just read in before trying again. This could leak > > xfs_vnode structures when there is memory pressure. Noticed > > by Christoph Hellwig. > > What we're leaking would be the xfs_inode. But this is exactly > the patch I had so OK from me :) Now that you're hopefully safe home can you commit it and push it for .25? |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [REVIEW] Don't make lazy counters default for mkfs, Eric Sandeen |
|---|---|
| Next by Date: | PARTIAL TAKE 977823 - fix inode leak in xfs_iget_core(), Lachlan McIlroy |
| Previous by Thread: | TAKE 976035 - Remove superflous xfs_readsb call in xfs_mountfs., donaldd |
| Next by Thread: | PARTIAL TAKE 977823 - fix inode leak in xfs_iget_core(), Lachlan McIlroy |
| Indexes: | [Date] [Thread] [Top] [All Lists] |