xfs
[Top] [All Lists]

Re: [REVIEW] Don't make lazy counters default for mkfs

To: Mark Goodwin <markgw@xxxxxxx>
Subject: Re: [REVIEW] Don't make lazy counters default for mkfs
From: "Josef 'Jeff' Sipek" <jeffpc@xxxxxxxxxxxxxx>
Date: Sun, 2 Mar 2008 20:15:59 -0500
Cc: Timothy Shimmin <tes@xxxxxxx>, nscott@xxxxxxxxxx, Russell Cattelan <cattelan@xxxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxxx>, Barry Naujok <bnaujok@xxxxxxx>, "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
In-reply-to: <47CB4696.1030304@sgi.com>
References: <op.t67mtawg3jf8g2@pc-bnaujok.melbourne.sgi.com> <1204166101.13569.102.camel@edge.scott.net.au> <47C87775.2010007@thebarn.com> <47C89137.3070805@sandeen.net> <47C89303.7070902@thebarn.com> <1204500895.10190.3.camel@edge.scott.net.au> <47CB434B.4040005@sgi.com> <47CB4696.1030304@sgi.com>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.16 (2007-06-11)
On Mon, Mar 03, 2008 at 11:30:14AM +1100, Mark Goodwin wrote:
...
> Maybe I'm missing something, but if we export all the feature bits,
> both new and old, then (a) an old mkfs will continue to ignore them,
> and (b) future versions of mkfs will have all the information needed,
> but will need t be smart about how that information is used.

IMHO:

1) mkfs should make a filesystem, the defaults should be conservative (say
   using features that have been around >1 year)

2) xfs should export supported features to userspace

3) if you want to make sure that the fs you create will be mountable with
   your current kernel, write a small shell script or something along those
   lines that reads the features from some kernel interface, and based on
   those passes the right options to mkfs

4) if you just use mkfs and it creates a fs that's incompatible with your
   current kernel, the mount will fail - as it does today, but perhaps a
   less cryptic error message would be in order

Since installers are just gigantic wrappers around basic commands like mkfs,
#3 gets nicely covered.

Josef 'Jeff' Sipek.

-- 
The reasonable man adapts himself to the world; the unreasonable one
persists in trying to adapt the world to himself. Therefore all progress
depends on the unreasonable man.
                - George Bernard Shaw


<Prev in Thread] Current Thread [Next in Thread>